-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more scaffolding updates #511
Merged
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
7064708
defend against rather common empty output scenario
dpark01 0593083
more compliant wdl
dpark01 0bedc96
add new wdl task report_primary_kraken_taxa
dpark01 98f9bbd
add report_primary_kraken_taxa wdl task and add to classify_single
dpark01 e39919b
add a few more outputs
dpark01 a85d7c9
Merge remote-tracking branch 'origin/master' into dp-scaffold
dpark01 9e12088
try wdl 1.1 and see what happens
dpark01 02cf671
try wdl development and see what happens
dpark01 d824518
update to take tsv instead of json input for reference/tax map
dpark01 fa07252
attempt to not fail in scaffolding when some but not all segments of …
dpark01 031a294
forgot $
dpark01 8a9b26f
remove random empty newline introduced in this branch
dpark01 165eb66
fix bash logical construction
dpark01 8c898c9
Merge remote-tracking branch 'origin/master' into dp-scaffold
dpark01 1080d49
initial draft of task for filtering reference list
dpark01 1a77bf7
pre-extract taxdump tarball
dpark01 d31c14a
add optional kraken-based reference selection to multitaxa
dpark01 526cece
why cromwell do you behave poorly on edge cases
dpark01 f02a58b
more stats and outputs, revert to refbased if cant denovo, dont polis…
dpark01 ca24b2d
Merge remote-tracking branch 'origin/master' into dp-scaffold
dpark01 bc6bee7
simplify cromwell fix
dpark01 6a71e1a
Merge branch 'master' into dp-scaffold
dpark01 93d455f
bump viral-classify 2.2.3.0 to 2.2.4.1
dpark01 88ca4d1
revert version
dpark01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason we can't make this type
Map[ String, Map[String,String] ]
, where the outer mapString
keys are thetaxid
ortax_name
values? (for picking out values for a given taxon in downstream analyses)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly just because of how we construct it (see the scatter in the WDL above), and that WDL 1.0 lacks a lot of the basic methods for navigating
Map
s and converting back and forth withArray
s.