Make Pipelines Azure compatible Closes #143 #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dpark01 I have made the pipeline Azure compatible looking. Testing also seems to be working. |
dpark01
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
Wow this is super helpful thanks!
So the disk / disks thing was the only necessary change to make it work on TES?
Would you have any interest in helping out https://github.com/theiagen/public_health_viral_genomics as well with the transition?
|
@dpark01 That was the majority of the changes. We have been working on cromwell on azure changes to enable minimal changes from you side. Will take a look at the public health as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #143