Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextclade 2.0 updates #430

Merged
merged 3 commits into from
Jun 28, 2022
Merged

nextclade 2.0 updates #430

merged 3 commits into from
Jun 28, 2022

Conversation

dpark01
Copy link
Member

@dpark01 dpark01 commented Jun 28, 2022

Update nextclade docker from 1.11.0 to 2.0.0.

  • The CLI arguments in v2 are slightly different. See changelog and nextclade --help
  • After v2 is released, Nextclade v1 will no longer be supported - there will be no software updates. Datasets for v1 will stay online, and they might receive occasional updates, but Nextclade will not be able to take advantage of improvements in v2. We recommend to upgrade soon.
  • Nextstrain's ncov-ingest and ncov repositories will switch to nextclade/nextalign v2 during this period
  • Nextstrain's monkeypox repo already uses v2 beta

Please adjust your scripts and workflows accordingly to avoid sudden breakage.

@dpark01 dpark01 marked this pull request as ready for review June 28, 2022 16:58
@dpark01 dpark01 merged commit 68d1288 into master Jun 28, 2022
@dpark01 dpark01 deleted the pangolin branch June 28, 2022 16:58
~{"--input-gene-map " + gene_annotations_json} \
~{"--input-pcr-primers " + pcr_primers_csv} \
~{"--input-virus-properties " + virus_properties} \
--output-basename "~{basename}" \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was also throwing things off for me. Seemed as if it was looking for intermediate files that weren't tagged appropriately. Removing this and explicitly naming the output files below seemed to suffice.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which was throwing things off, --output-basename? I think in combination with --output-all it works.

I managed to get the nextclade_one_sample passing in Github Actions, and I tested the nextclade_many_samples task on some recent production data just fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants