Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus calling major_cutoff knobs and defaults #424

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Conversation

dpark01
Copy link
Member

@dpark01 dpark01 commented Jun 6, 2022

The major_cutoff parameter for consensus genome generation (ultimately implemented here) produces IUPAC ambiguity bases in the output assembly at positions where there is significant read support for non-major alleles. The parameter (a value from 0.0 to 1.0) defines the threshold. If the major allele frequency (the frequency of the allele with highest count) is strictly above this threshold, then a single non-ambiguous base will be called at that position. If it is equal to or below the threshold, an appropriate IUPAC ambiguity base will be chosen that represents the possible set of (2 or more) alleles seen in the alignment.

  • Expose the major_cutoff knob to the outer levels of the assemble_refbased and sarscov2_illumina_full WDL workflows (they were previously only exposed at the task level).
  • Change the default value of major_cutoff for both workflows to 0.75 (for sarscov2_illumina_full since it is mostly governed by contractual requirements, and for assemble_refbased because it seems to be a more sensible value than the old default of 0.5, which only calls 2-allele ambiguity codes when exact 50-50 read support is observed).

…ov2_illumina_full workflows and change default value to 0.75 in both cases
@dpark01 dpark01 marked this pull request as ready for review June 6, 2022 14:40
@dpark01 dpark01 merged commit e3d642a into master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant