Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorporate assemble_refbased as refine/polish for denovo #422

Merged
merged 10 commits into from
May 26, 2022

Conversation

dpark01
Copy link
Member

@dpark01 dpark01 commented May 23, 2022

This PR takes the latest updates of assemble_refbased in the past couple years and incorporates them (directly as a subworkflow) as the refine/polish steps of de novo assembly.

Various updates:

  • assemble_refbased: add lofreq vcf outputs by default
  • scaffolding: change default imputation aligner from muscle to mummer (keep it big-genome friendly by default)
  • remove some vestigal WDL code
  • more allowNestedInputs by default (expose subworkflow and task level optional inputs to user)
  • replace polish/refine steps in assemble_denovo and scaffold_and_refine workflows with assemble_refbased as a subworkflow call

This does not currently enable scattering on multiple input bams for assemble_denovo/scaffold_and_refine, that can be for a future PR.

@dpark01 dpark01 marked this pull request as ready for review May 23, 2022 22:38
@dpark01 dpark01 merged commit a47d310 into master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant