default to minimap2 for assemble_refbased #123
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes commits for:
aligner_options
properly whenaligner
is something other than default/novoalignminimap2
A minimap2-based test run on 1500 SARS-CoV-2 genomes is in flight over here. Pilot test on 44 edge-case genomes (ie on the edge of being considered an acceptable assembly) shows that minimap2 is consistently faster (at least 2x) than licensed novoalign and always has an aligned read count greater than or equal to novoalign's (usually pretty close).
Assuming the test run looks consistent with previous novoalign-based outputs, this change has the benefit of
PL
tag (whether or not that's actually a good idea is left to the discretion of the user).