Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update htsjdk to 3.0.1 #1831

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Update htsjdk to 3.0.1 #1831

merged 2 commits into from
Oct 5, 2022

Conversation

lbergelson
Copy link
Member

Checklist (never delete this)

Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.

Content

- [ ] Added or modified tests to cover changes and any new functionality
- [ ] Edited the README / documentation (if applicable)

  • All tests passing on Travis

Review

  • Final thumbs-up from reviewer
  • Rebase, squash and reword as applicable

For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests

@lbergelson lbergelson requested a review from droazen September 26, 2022 20:29
@lbergelson
Copy link
Member Author

@droazen PR to update htsjdk to 3.0.1.

* upgrade htsjdk to 3.0.1 and replace use of a newly deprecated method
@droazen
Copy link
Contributor

droazen commented Sep 27, 2022

@lbergelson Looks like there are a bunch of test failures here related to changes from the new HTSJDK release...

Copy link
Contributor

@droazen droazen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me

@lbergelson lbergelson merged commit 533e880 into master Oct 5, 2022
@lbergelson lbergelson deleted the lb_update_htsjdk branch October 5, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants