This PR skips avoids merging fingerprints when there's only one finge… #1826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks to be equivalent to the old code when there are > 1 fingerprints, and then handles the = 1 case manually. Are there any existing tests somewhere which cover the = 1 case to ensure nothing breaks? |
kachulis
approved these changes
Sep 14, 2022
| final Fingerprint sampleFp = new Fingerprint(firstDetail.sample, null, by.apply(firstDetail)); | ||
| entry.getValue().stream().map(Map.Entry::getValue).collect(Collectors.toSet()).forEach(sampleFp::merge); | ||
| return sampleFp; | ||
| Set<Fingerprint> fingerprintsSet = entry.getValue().stream().map(Map.Entry::getValue).collect(Collectors.toSet()); |
| @@ -151,21 +151,28 @@ public static Map<FingerprintIdDetails, Fingerprint> mergeFingerprintsBy( | |||
| .collect(Collectors.toMap( | |||
| entry -> { | |||
| // merge the keys (unequal values are eliminated by merge). | |||
|
|
|||
| List<Map.Entry<FingerprintIdDetails, Fingerprint>> entryList = entry.getValue(); | |||
|
@yfarjoun If you still need this can you do a rebase and then 👍 to merge? |
…rprint to be merged. The merge operation performs a deep copy of the haplotype probabilities array and effectively doubles the memory requirements of the program after having loaded the fingerprints from the sources.
…takes that much memory....
lbergelson
force-pushed
the
yf_optimize_memory_usage_during_crosscheck
branch
from
180b998 to
6f8a91c
Compare
lbergelson
force-pushed
the
yf_optimize_memory_usage_during_crosscheck
branch
from
6f8a91c to
55de0c6
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rprint to be merged. The merge operation performs a deep copy of the haplotype probabilities array and effectively doubles the memory requirements of the program after having loaded the fingerprints from the sources.
Description
Give your PR a concise yet descriptive title
Please explain the changes you made here.
Explain the motivation for making this change. What existing problem does the pull request solve?
Mention any issues fixed, addressed or otherwise related to this pull request, including issue numbers or hard links for issues in other repos.
You can delete these instructions once you have written your PR description.
Checklist (never delete this)
Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.
Content
Review
For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests