Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added README file and image files it references #541

Merged
merged 62 commits into from
Oct 27, 2023
Merged

Added README file and image files it references #541

merged 62 commits into from
Oct 27, 2023

Conversation

Ian-Erickson
Copy link
Collaborator

Lreg.png and LSeg.png are those image files. README is a first draft and under review.

Lreg.png and LSeg.png are those image files. README is a first draft and under review.
…magnetic resonance–derived left ventricular mass to be a link.
Attempting to have the images render correctly.
…Variant.

Additionally removed unnecessary linebreak.
I wasn't sure if it made sense in the README.
"Machine learning enables new insights into clinical significance of and genetic contributions to liver fat accumulation" to be exact. I believe I have found the specific paper about this model.
…c Magnetic Resonance-Derived Left Ventricular Mass and Hypertrophy from 12-Lead Electrocardiograms"

The paper links directly back the ML4H Github.
…mages" a link to the article describing the model.
…aper on this model.

The heading of this README was not close to the title of the paper. So I decided to put the link in the citation instead.
I may have had it link to a very similar article from the same authors.
…article.

I can't tell if the names of the same article are different, or they're two different but very similar articles.
…student_and_mri_teacher.

Moved description of each model to their own line for easier reading. Also changed some commas to periods. Also made the sentence "Three pre-trained models are included here" end in a colon.
…entricular_mass

Put some sentences on the same line, changed the tense to present tense in the 4th line, and removed the line from the original paper pointing the reader back to this Github.
…the image in the README link directly to the added local file.
… down the alt text of the images.

(cardiac_mri_derived_left_ventricular_mass/README.md)
Please correct me if "the models were trained with the InlineVF contours" and "we trained with the InlineVF" are not equivalent statements.
The README of cardiac_mri_derived_left_ventricular_mass to be exact.
Ian-Erickson and others added 25 commits October 13, 2023 15:32
architecture_graph_sax_diastole_segment_no_flat.png is not returning.
All images which matches it's description "An overview of the models layers" were already in the results section.
Deleting test image with git rm looks very different from using git rm on an image tracked with git lfs.
This appears to be the version on Github despite not being on my local machine...
The capital S one shouldn't be there. But doing this removes Lseg with a lower case L.
Copy link
Collaborator

@lucidtronix lucidtronix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ian-Erickson !

@lucidtronix lucidtronix merged commit 5eeba94 into master Oct 27, 2023
3 checks passed
@lucidtronix lucidtronix deleted the READMEs branch October 27, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants