Add function parse_variant to create a Struct with the locus and alleles from a variant string or contig, position, ref, and alt.
#746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leles from a variant string or contig, position, ref, and alt.
KoalaQin
reviewed
Dec 19, 2024
|
|
||
| @pytest.mark.parametrize( | ||
| "variant_str, contig, position, ref, alt, build, expected", | ||
| [ |
There was a problem hiding this comment.
I've never used pytest myself, you only need to put some representative valid and invalid sennarios, right?
There was a problem hiding this comment.
Yeah, it's just adding unit tests so that if we change the code and it breaks it, then hopefully the test will fail
|
I just forgot to add tests to the other PR where I changed a function. We are trying to add tests now whenever we add a new function or change a function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.