Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retain cdf option for median calculations when computing info fields #731

Merged
merged 15 commits into from
Sep 23, 2024
Merged

Add retain cdf option for median calculations when computing info fields #731

merged 15 commits into from
Sep 23, 2024

Conversation

klaricch
Copy link
Contributor

No description provided.

@klaricch klaricch requested a review from jkgoodrich September 19, 2024 19:53
@klaricch klaricch self-assigned this Sep 19, 2024
@klaricch klaricch changed the title Ddd retain cdf option for median calculations when computing info fields Add retain cdf option for median calculations when computing info fields Sep 19, 2024
@jkgoodrich jkgoodrich self-assigned this Sep 19, 2024
jkgoodrich
jkgoodrich reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions and some small changes

klaricch and others added 7 commits September 20, 2024 13:02
@klaricch @jkgoodrich
Update gnomad/utils/sparse_mt.py
37f74fd 
Co-authored-by: jkgoodrich <33063077+jkgoodrich@users.noreply.github.com>
@klaricch @jkgoodrich
Update gnomad/utils/sparse_mt.py
1cced6f 
Co-authored-by: jkgoodrich <33063077+jkgoodrich@users.noreply.github.com>
@klaricch @jkgoodrich
Update gnomad/utils/sparse_mt.py
367f8fa 
Co-authored-by: jkgoodrich <33063077+jkgoodrich@users.noreply.github.com>
@klaricch @jkgoodrich
Update gnomad/utils/sparse_mt.py
9327309 
Co-authored-by: jkgoodrich <33063077+jkgoodrich@users.noreply.github.com>
@klaricch @jkgoodrich
Update gnomad/utils/sparse_mt.py
3d60a33 
Co-authored-by: jkgoodrich <33063077+jkgoodrich@users.noreply.github.com>
@klaricch
Add comments and k param
aa09ec6
@klaricch
fill in cdf_k
a947162
@klaricch klaricch requested a review from jkgoodrich September 23, 2024 14:20
jkgoodrich
jkgoodrich approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some docstring param formatting, sorry about the OCD

Otherwise, LGTM!

klaricch and others added 5 commits September 23, 2024 13:06
@klaricch @jkgoodrich
Update gnomad/utils/sparse_mt.py
5c74366 
Co-authored-by: jkgoodrich <33063077+jkgoodrich@users.noreply.github.com>
@klaricch @jkgoodrich
Update gnomad/utils/sparse_mt.py
3072203 
Co-authored-by: jkgoodrich <33063077+jkgoodrich@users.noreply.github.com>
@klaricch @jkgoodrich
Update gnomad/utils/sparse_mt.py
a76a84a 
Co-authored-by: jkgoodrich <33063077+jkgoodrich@users.noreply.github.com>
@klaricch @jkgoodrich
Update gnomad/utils/sparse_mt.py
56188b9 
Co-authored-by: jkgoodrich <33063077+jkgoodrich@users.noreply.github.com>
@klaricch
black
4d03a9d
@klaricch klaricch merged commit 85906c4 into main Sep 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkgoodrich jkgoodrich jkgoodrich approved these changes

Assignees

@klaricch klaricch

@jkgoodrich jkgoodrich

Labels
Changelog: new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klaricch @jkgoodrich