Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSDEEPB-716 Exit cleanly with bad WDL. #81

Merged
merged 1 commit into from
Jul 8, 2015
Merged

DSDEEPB-716 Exit cleanly with bad WDL. #81

merged 1 commit into from
Jul 8, 2015

Conversation

mcovarr
Copy link
Contributor

@mcovarr mcovarr commented Jul 6, 2015

No description provided.

scottfrazer
scottfrazer reviewed Jul 7, 2015
View reviewed changes
src/test/scala/cromwell/util/SampleWdl.scala
| input: bfile=bfile
| }
|}
""".stripMargin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if I'm understanding this correctly, this WDL is supposed to be malformed? If so, then I don't see how

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cromwell certainly doesn't like it as it is now. 😄 Do we currently support workflow inputs this way?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, this will soon be valid unless I'm missing something obvious. Does any syntax error work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in-person conversation: I'll fix this in my branch when this syntax becomes valid.

@geoffjentry
Copy link
Contributor

👍

geoffjentry added a commit that referenced this pull request Jul 8, 2015
@geoffjentry
Merge pull request #81 from broadinstitute/mlc_716
71d5e71 
DSDEEPB-716 Exit cleanly with bad WDL.
@geoffjentry geoffjentry merged commit 71d5e71 into develop Jul 8, 2015
@geoffjentry geoffjentry deleted the mlc_716 branch July 8, 2015 03:55
mcovarr pushed a commit that referenced this pull request Oct 4, 2017
@cjllanwarne
Merge pull request #81 from broadinstitute/cjl_array_construction_checks
cc58e9b 
Enforce coersion during array construction
mcovarr pushed a commit that referenced this pull request Oct 21, 2017
@ruchim
removing jes tests closes #81 (#82)
22a2969 
* removing jes tests

* took out the optionalTestPath directory

* reword

* reverting parallel script to normality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcovarr @geoffjentry @scottfrazer