WX-1873 Replace output move option with "copy & update output location" #7565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgainerdewar
approved these changes
Sep 30, 2024
| case object FinalWorkflowOutputsMode extends WorkflowOption("final_workflow_outputs_mode") { | ||
| // Default to Copy because that was originally the only behavior | ||
| def fromString(s: Option[String]): FinalWorkflowOutputsMode = | ||
| case object FinalWorkflowOutputsDirMetadata extends WorkflowOption("final_workflow_outputs_dir_metadata") { |
There was a problem hiding this comment.
As long as it's well-documented (which it looks like it is) I think this is OK as is, but agree that the naming is awkward. Might be easier to name if it were a boolean, something like FinalWorkflowOutputsDirStoredInOutputs? 😬
salonishah11
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces #7472
As I complained in Slack, I dislike a lot of the naming in this PR. Suggestions welcome.
Release Notes Confirmation
CHANGELOG.mdCHANGELOG.mdin this PRCHANGELOG.mdbecause it doesn't impact community usersTerra Release Notes