Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WX-927 call caching prefixes removed from GCP Batch backend #7559

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

mcovarr
Copy link
Contributor

@mcovarr mcovarr commented Sep 25, 2024

Description

Call caching prefixes and blacklist removed from GCP Batch backend.

Release Notes Confirmation

CHANGELOG.md

  • I updated CHANGELOG.md in this PR
  • I assert that this change shouldn't be included in CHANGELOG.md because it doesn't impact community users

Terra Release Notes

  • I added a suggested release notes entry in this Jira ticket
  • I assert that this change doesn't need Jira release notes because it doesn't impact Terra users

@mcovarr mcovarr marked this pull request as ready for review September 25, 2024 17:35
@mcovarr mcovarr requested a review from a team as a code owner September 25, 2024 17:35
Copy link
Collaborator

@aednichols aednichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The relation between blacklist and prefixes is confusing, but it does look like we use the blacklist: https://github.com/broadinstitute/terra-helmfile/blob/master/charts/cromwell/templates/config/_cromwell.conf.tpl#L221-L245

@mcovarr
Copy link
Contributor Author

mcovarr commented Sep 25, 2024

Oh wow, I completely misremembered that. I'll back out the blacklist changes.

@mcovarr mcovarr force-pushed the wx_927_call_caching_prefixes_and_blacklist branch from 28dbeb6 to 81d31a2 Compare September 25, 2024 18:12
@mcovarr mcovarr changed the title WX-927 call caching prefixes and blacklist removed from GCP Batch backend WX-927 call caching prefixes removed from GCP Batch backend Sep 25, 2024
@mcovarr mcovarr merged commit edc8918 into develop Sep 27, 2024
37 checks passed
@mcovarr mcovarr deleted the wx_927_call_caching_prefixes_and_blacklist branch September 27, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants