Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WX-927 enabling lots of GCP Batch Centaur tests #7546

Merged
merged 13 commits into from
Sep 25, 2024
Merged

Conversation

mcovarr
Copy link
Contributor

@mcovarr mcovarr commented Sep 17, 2024

Description

Release Notes Confirmation

CHANGELOG.md

  • I updated CHANGELOG.md in this PR
  • I assert that this change shouldn't be included in CHANGELOG.md because it doesn't impact community users

Terra Release Notes

  • I added a suggested release notes entry in this Jira ticket
  • I assert that this change doesn't need Jira release notes because it doesn't impact Terra users

@mcovarr mcovarr marked this pull request as ready for review September 24, 2024 23:25
@mcovarr mcovarr requested a review from a team as a code owner September 24, 2024 23:25
@@ -0,0 +1,4 @@
{
"gcp_batch_gcs_root": "gs://cloud-cromwell-dev-self-cleaning",
"call_cache_hit_path_prefixes": []
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think call caching prefixes might be another thing that we implemented but never shipped in Terra, any potential cleanup would sensibly be a different story.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok cool, I'll remove the prefix changes from this branch and take that up in a different PR

@mcovarr mcovarr merged commit efac63f into develop Sep 25, 2024
37 checks passed
@mcovarr mcovarr deleted the wx_927_problems branch September 25, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants