A more thorough Hello World restart test. #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcovarr
force-pushed
the
mlc_really_restart
branch
from
acbbcc9 to
e750db9
Compare
| } | ||
| // The caller doesn't care about the result value, only that it's a Future. | ||
| // Use Future.sequence to manipulate Seq[Future[Unit]] to Future[Seq[Unit]], then map to Future[Unit]. | ||
| Future.sequence(seqOfFutures) map { _ => () } |
There was a problem hiding this comment.
Why do you need that map?
There was a problem hiding this comment.
The expression doesn't typecheck to the return type without it.
There was a problem hiding this comment.
It would typecheck to Future[Any]; maybe I should switch to that?
mcovarr
force-pushed
the
mlc_really_restart
branch
from
e750db9 to
344381c
Compare
|
Looks good. Merging. |
kshakir
added a commit
that referenced
this pull request
Jul 2, 2015
A more thorough Hello World restart test.
mcovarr
pushed a commit
that referenced
this pull request
Oct 4, 2017
Support for empty array literals
mcovarr
pushed a commit
that referenced
this pull request
Oct 21, 2017
* Enable workflow log copy test * Remove obsolete comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessitated some actual fixes to the code to do the Right Thing for the LocalBackend.