Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WX-1338 Fix cron invocation of E2E test #7244

Merged
merged 6 commits into from
Nov 3, 2023
Merged

WX-1338 Fix cron invocation of E2E test #7244

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0ff5d85
Don't specify dsp-reusable-workflows branch
jgainerdewar Oct 30, 2023
b413a03
Temporarily change branch for testing
jgainerdewar Oct 31, 2023
c8992ab
Revert branch
jgainerdewar Oct 31, 2023
5e4eb34
Remove remaining inputs
jgainerdewar Nov 1, 2023
720a26e
Merge branch 'develop' into jgd_WX-1338
jgainerdewar Nov 1, 2023
abcfdfe
Merge branch 'develop' into jgd_WX-1338
jgainerdewar Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/workflows/azure_e2e_run_workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,6 @@ on:
- cron: '0 16 * * *' # UTC 4pm, EST 11am, EDT 12pm
workflow_dispatch:
inputs:
target-branch:
description: 'Branch name of dsp-reusable-workflows repo to run tests on'
Copy link
Contributor

@JVThomas JVThomas Nov 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, scheduled jobs don't accept inputs, so if there are inputs referenced in the workflow Github will just pass in an empty value.

Removing the branch input is a good idea, I initially included it to test against the feature branch

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, fascinating! The other inputs must have already been using a default value from the workflow we dispatch to. I'm going to remove all the inputs to reduce confusion, we can add them back in if needed for testing.

required: true
default: 'main'
type: string
owner-subject:
description: 'Owner of billing project'
required: true
Expand Down Expand Up @@ -85,7 +80,6 @@ jobs:
id-token: write
uses: "broadinstitute/dsp-reusable-workflows/.github/workflows/cromwell-az-e2e-test.yaml@main"
with:
branch: "${{ inputs.target-branch }}"
bee-name: "${{ needs.params-gen.outputs.bee-name }}"
billing-project-name: "${{ needs.params-gen.outputs.project-name }}"

Expand Down