Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WX-1156] TES Backend Parameter #7169

Closed
wants to merge 6 commits into from
Closed

[WX-1156] TES Backend Parameter #7169

wants to merge 6 commits into from

Conversation

THWiseman
Copy link
Contributor

TES 4.4 accepts a backend parameter internal_path_prefix that allows cromwell to specify a directory for TES to write its output files to. This change adds a key/value pair to the TES task runtime attributes specify the task_root/tes_task/ directory as the preferred one.

@THWiseman THWiseman requested a review from a team as a code owner June 30, 2023 15:20
// TES accepts a key/value pair in its backend parameters that specifies
// the directory to use for files related to this task.
val tesTaskPathPrefix : (String, Option[String]) = ("internal_path_prefix",
Option(tesPaths.callExecutionRoot.resolve("tes_task").pathAsString))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to elevate this TES working directory to be part of TesJobPaths so we can easily reference it from other places (ex. your upcoming work to include files in that dir in metadata).

It's a little weird, though, because it's implementation-specific and not part of the TES spec, so we'd need to be careful to not blow up when it doesn't exist.

@THWiseman THWiseman closed this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants