Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WX-1101 Update library versions to support batch #7155

Merged
merged 4 commits into from
Jul 6, 2023

Conversation

dspeck1
Copy link
Collaborator

@dspeck1 dspeck1 commented Jun 7, 2023

Update google cloud and related libraries to new versions to support Google Cloud Batch

@dspeck1 dspeck1 requested a review from aednichols June 7, 2023 17:02
@dspeck1 dspeck1 requested a review from a team as a code owner June 7, 2023 17:02
@aednichols aednichols changed the title Update library versions to support batch WX-1101 Update library versions to support batch Jun 7, 2023
Copy link
Collaborator

@aednichols aednichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added our internal change management number and will circulate with the team

@jgainerdewar
Copy link
Contributor

I see a unit test failure that looks like it could be the result of one of these upgrades:

should not mix up credentials *** FAILED *** (44 milliseconds)
[info]   java.lang.NoSuchFieldException: credentials
[info]   at java.base/java.lang.Class.getDeclaredField(Class.java:2411)
[info]   at cromwell.filesystems.gcs.GcsPathBuilderSpec.credentialsForPath$1(GcsPathBuilderSpec.scala:326)
[info]   at cromwell.filesystems.gcs.GcsPathBuilderSpec.$anonfun$new$7(GcsPathBuilderSpec.scala:334)
[info]   at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
[info]   at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
[info]   at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
[info]   at org.scalatest.Transformer.apply(Transformer.scala:22)
[info]   at org.scalatest.Transformer.apply(Transformer.scala:20)
[info]   at org.scalatest.flatspec.AnyFlatSpecLike$$anon$5.apply(AnyFlatSpecLike.scala:1832)
[info]   at org.scalatest.TestSuite.withFixture(TestSuite.scala:196)

@aednichols
Copy link
Collaborator

@dspeck1 I updated this branch to trigger another CI run, let's see what happens

@jgainerdewar jgainerdewar merged commit 4ea3a05 into develop Jul 6, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants