Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WX-1010 Update Github Actions set output syntax #7111

Merged
merged 3 commits into from
Apr 6, 2023
Merged

WX-1010 Update Github Actions set output syntax #7111

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d3e26d
Update GHA set output syntax
aednichols Apr 4, 2023
63689dc
Update GHA set output syntax
aednichols Apr 4, 2023
35d4f6b
Merge branch 'develop' into aen_gha_update
aednichols Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/make_publish_prs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
git config --global user.email "broadbot@broadinstitute.org"
git commit -m "Updating Cromwell version to ${NEW_CROMWELL_V}"
git push https://broadbot:$BROADBOT_GITHUB_TOKEN@github.com/broadinstitute/firecloud-develop.git ${NEW_BRANCH_NAME}
echo ::set-output name=NEW_BRANCH_NAME::${NEW_BRANCH_NAME}
echo "{NEW_BRANCH_NAME}=${NEW_BRANCH_NAME}" >> $GITHUB_OUTPUT
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be NEW_BRANCH_NAME =${NEW_BRANCH_NAME}" >> $GITHUB_OUTPUT

- name: Create firecloud-develop PR
uses: actions/github-script@v6
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/trivy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:

# export image name from the log
image=$(grep 'Tagging image' build.log | awk '{print $NF}')
echo "::set-output name=image::${image}"
echo "{image}=${image}" >> $GITHUB_OUTPUT
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here: image=${image}" >> $GITHUB_OUTPUT


# scan the image
- uses: broadinstitute/dsp-appsec-trivy-action@v1
Expand Down