BT-684 Initial Blob Storage Impl #6810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraefrei
commented
Jul 20, 2022
kraefrei
commented
Jul 20, 2022
filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobPathBuilder.scala
Outdated
Show resolved
Hide resolved
kraefrei
commented
Jul 20, 2022
filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobPathBuilder.scala
Outdated
Show resolved
Hide resolved
filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobPathBuilder.scala
Outdated
Show resolved
Hide resolved
filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobPathBuilder.scala
Show resolved
Hide resolved
filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobPathBuilder.scala
Outdated
Show resolved
Hide resolved
filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobPathBuilder.scala
Outdated
Show resolved
Hide resolved
filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobPathBuilder.scala
Show resolved
Hide resolved
filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobPathBuilder.scala
Outdated
Show resolved
Hide resolved
filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobPathBuilder.scala
Show resolved
Hide resolved
filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobPathBuilderFactory.scala
Outdated
Show resolved
Hide resolved
filesystems/blob/src/test/scala/cromwell/filesystems/blob/BlobPathBuilderSpec.scala
Show resolved
Hide resolved
filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobPathBuilder.scala
Outdated
Show resolved
Hide resolved
filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobPathBuilder.scala
Outdated
Show resolved
Hide resolved
filesystems/blob/src/test/scala/cromwell/filesystems/blob/BlobPathBuilderSpec.scala
Show resolved
Hide resolved
kraefrei
commented
Jul 25, 2022
filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobPathBuilderFactory.scala
Outdated
Show resolved
Hide resolved
kraefrei
commented
Jul 25, 2022
filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobPathBuilder.scala
Outdated
Show resolved
Hide resolved
jgainerdewar
approved these changes
Jul 25, 2022
|
Should be OK to go ahead and merge without the code coverage approval - it reflects the tests that actually ran on this PR, so it's finding none. If there's a way to only ignore the test we expect to fail, might be nice, but not a blocker for this PR IMO. |
mspector
reviewed
Jul 26, 2022
| * pathToFile -> test/testFile.wdl | ||
| * | ||
| * If the configured container and storage account do not match, the string is considered unparsable | ||
| */ |
There was a problem hiding this comment.
This is a nice explanation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.