Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment about disabling SSH access test [CROM-6872] #6732

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

breilly2
Copy link
Contributor

No description provided.

Copy link
Contributor

@mspector mspector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious: should we not just get rid of the test entirely?

@breilly2
Copy link
Contributor Author

Deleting the test is an option. There's enough here that, if we wanted to revive the test, I wouldn't want anyone to have to start from scratch. While we know that we could search through git history to find and revive it, someone in the future might not. I know that we've chosen to not prioritize this feature right now, but I don't think that necessarily means that we don't care about it at all.

@breilly2 breilly2 merged commit 06eb982 into develop Apr 14, 2022
@aednichols aednichols deleted the br_crom-6872_clarify branch April 22, 2022 19:50
ovesh added a commit to deepgenomics/cromwell that referenced this pull request Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants