Initial JES backend work #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cp /cromwell/docker/run.sh /etc/service/cromwell/run | ||
|
|
||
| # FIXME - now need to set the conf file specifically |
There was a problem hiding this comment.
I'd forgotten about this. I modified stuff to use application.conf the correct way (via ConfigFactory.load) instead of the local file link. We shouldn't be doing this stuff at all - however when the server loads up on the VM we will need to pass in some credentials. Unclear at this moment the best way to do that - looking into it
| } | ||
|
|
||
| def +(value: String): GoogleCloudStoragePath = { | ||
| if (objectName.endsWith("/") || value.startsWith("/")) { |
There was a problem hiding this comment.
what if these are both true?
geoffjentry
force-pushed
the
jes_backend_4
branch
from
c4cca6f to
96b226e
Compare
| @@ -189,11 +190,14 @@ class SlickDataAccess(databaseConfig: Config, val dataAccess: DataAccessComponen | |||
| executionInsert.executionId.get, | |||
| None, | |||
| None) | |||
| case j: JesBackend => | |||
| dataAccess.localJobsAutoInc += new LocalJob(executionInsert.executionId.get, None, None) // FIXME: Placeholder? | |||
There was a problem hiding this comment.
Doesn't appear there are any current DataAccess callers that are actually using these tables, but this should eventually be dataAccess.jesJobsAutoInc, not localJobsAutoInc.
There was a problem hiding this comment.
And presumably JesJob?
geoffjentry
force-pushed
the
jes_backend_4
branch
from
ede05d5 to
c4ee9cb
Compare
# The first commit's message is: Initial JES backend work # The 2nd commit message will be skipped: # Make application.conf basic
geoffjentry
force-pushed
the
jes_backend_4
branch
from
c4ee9cb to
93250fa
Compare
mcovarr
pushed a commit
that referenced
this pull request
Oct 4, 2017
mcovarr
pushed a commit
that referenced
this pull request
Oct 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.