Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*Allow processPositionalArguments to be overridden in docgen subclasses. #159

Merged
merged 2 commits into from
Mar 10, 2020

Conversation

cmnbroad
Copy link
Collaborator

@cmnbroad cmnbroad commented Mar 4, 2020

No description provided.

@cmnbroad cmnbroad changed the title Allow processPositionalArguments to be overridden in docgen subclasses. *Allow processPositionalArguments to be overridden in docgen subclasses. Mar 4, 2020
@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #159 into master will increase coverage by 1.49%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #159      +/-   ##
============================================
+ Coverage     76.72%   78.21%   +1.49%     
- Complexity      673      783     +110     
============================================
  Files            26       26              
  Lines          2307     2612     +305     
  Branches        456      562     +106     
============================================
+ Hits           1770     2043     +273     
- Misses          365      390      +25     
- Partials        172      179       +7
Impacted Files Coverage Δ Complexity Δ
...titute/barclay/help/DefaultDocWorkUnitHandler.java 76.87% <ø> (ø) 74 <0> (ø) ⬇️
...titute/barclay/argparser/CommandLineException.java 44.73% <0%> (-2.33%) 2% <0%> (ø)
...e/barclay/argparser/CommandLineArgumentParser.java 89.76% <0%> (-0.05%) 128% <0%> (+12%)
...ute/barclay/argparser/NamedArgumentDefinition.java 82.79% <0%> (+4.2%) 201% <0%> (+79%) ⬆️
...nstitute/barclay/argparser/ArgumentDefinition.java 76.83% <0%> (+6.4%) 37% <0%> (+11%) ⬆️
...arclay/argparser/PositionalArgumentDefinition.java 77.02% <0%> (+7.21%) 19% <0%> (+8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0abd84d...32d1912. Read the comment docs.

@cmnbroad cmnbroad requested a review from lbergelson March 9, 2020 20:20
@@ -439,7 +439,7 @@ private FieldDoc getFieldDocForCommandLineArgument(
return fieldDoc;
}

private void processPositionalArguments(
protected void processPositionalArguments(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, this should probably have javadoc if it's protected....

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reconsidered, this should have a comment. 👍 after that

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@cmnbroad
Copy link
Collaborator Author

thank you Louis!

@cmnbroad cmnbroad merged commit 47ade47 into master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants