-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*Allow processPositionalArguments to be overridden in docgen subclasses. #159
Conversation
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
============================================
+ Coverage 76.72% 78.21% +1.49%
- Complexity 673 783 +110
============================================
Files 26 26
Lines 2307 2612 +305
Branches 456 562 +106
============================================
+ Hits 1770 2043 +273
- Misses 365 390 +25
- Partials 172 179 +7
Continue to review full report at Codecov.
|
@@ -439,7 +439,7 @@ private FieldDoc getFieldDocForCommandLineArgument( | |||
return fieldDoc; | |||
} | |||
|
|||
private void processPositionalArguments( | |||
protected void processPositionalArguments( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, this should probably have javadoc if it's protected....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reconsidered, this should have a comment. 👍 after that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
thank you Louis! |
No description provided.