Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change http client library #216

Closed
wants to merge 1 commit into from
Closed

change http client library #216

wants to merge 1 commit into from

Conversation

dogTK
Copy link

@dogTK dogTK commented May 13, 2023

issue

When launching generate_tiny_10x_pbmc.py, which is located under CellBender/examples/remove_background/, an error occurs due to the dataset not being downloaded.

(base) hoge@dogTK remove_background % pwd
/Users/hoge/Desktop/CellBender/examples/remove_background
(base) hoge@dogTK remove_background % python generate_tiny_10x_pbmc.py
Downloading pbmc4k (CellRanger 2.1.0, v2 Chemistry)...
Could not retrieve pbmc4k (CellRanger 2.1.0, v2 Chemistry) -- cannot continue!
(base) hoge@dogTK remove_background % 

change point

change the http-clinet library from urllib.request to requests.

Things Checked

I checked to download the sample file.

@dogTK dogTK changed the title feat/change http client library change http client library May 13, 2023
@sjfleming
Copy link
Member

Thank you so much for contributing this @dogTK , but for now, I am going to close this PR in favor of the way it has been addressed in v0.3.0 and mentioned in #95

But if the fix in v0.3.0 ends up not working well, then I might reopen this and use your fix instead.

@sjfleming sjfleming closed this Aug 8, 2023
@sjfleming
Copy link
Member

Addressed in #238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants