-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NetBSD: Fix CPU usage and top info. #2101
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report the correct number of CPUs and calculate the per-CPU load. Start implementing a common BSD interface, as all BSD implementations use *slightly* different functions to achieve the same goal, and maintaining them in one place would be easier. Fixes brndnmtthws#2097.
github-actions
bot
added
sources
PR modifies project sources
build system
related to build system (CMake) and/or building process/assumptions
labels
Dec 5, 2024
✅ Deploy Preview for conkyweb canceled.
|
g0mb4
changed the title
[WIP] NetBSD: Fix CPU Usage.
NetBSD: Fix CPU usage and top info.
Dec 6, 2024
brndnmtthws
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! I'll add you as a collaborator.
* Shared or very similar code across BSDs. | ||
*/ | ||
|
||
#ifndef BSDCOMMON_H_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: you can just use #pragma once
in the future.
brndnmtthws
added
the
bug
related to incorrect existing implementation of some functionality
label
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
related to incorrect existing implementation of some functionality
build system
related to build system (CMake) and/or building process/assumptions
sources
PR modifies project sources
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report the correct number of CPUs and calculate the per-CPU load.
Populate top info.
I've started implementing a common BSD interface, as all BSD implementations use slightly different functions to achieve the same goal, and maintaining them in one place would be easier.
Fixes #2097.