Move color parse error message out of hex parser #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conkyweb canceled.
|
Caellian
changed the title
Caellian
force-pushed
the
tweak/color-parsing-error
branch
from
5bf3551 to
171b961
Compare
|
The test seems to be failing because it now catches an error in |
brndnmtthws
approved these changes
May 26, 2024
Simplifies parsing code, gives a better message and reduces responsibility of last parser to report errors. Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Make ctest print output on failure. Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Caellian
force-pushed
the
tweak/color-parsing-error
branch
from
171b961 to
fd0ed44
Compare
✅ Deploy Preview for conkyweb canceled.
|
Caellian
force-pushed
the
tweak/color-parsing-error
branch
from
fd0ed44 to
f83c707
Compare
Didn't intend to use CRIT_ERR, however, tests shouldn't crash because CRIT_ERR calls clean_up from conky.cc. Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Caellian
commented
Dec 9, 2024
| @@ -196,6 +196,7 @@ TEST_CASE("cpu_percentage and cpu_barval return correct values") { | |||
| REQUIRE(cpu_barval(&obj1) == Approx(0.507)); | |||
|
|
|||
| delete[] info.cpu_usage; | |||
| info.cpu_usage = nullptr; | |||
There was a problem hiding this comment.
This little thing is out of scope, but it causes any tests which attempt using CRIT_ERR to crash. Tests shouldn't use CRIT_ERR because it interrupts their execution, but it's better to handle it explicitly than as a side effect of another test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives a better error message if no parsers (possibly more in future) can parse the color.
This avoids issues like getting a misleading error message when color name parsing didn't work.
I'm making this change until I'm done with logging improvements (a few tweaks left, but not sure when I'll be able to clean up the code).