Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 3 list song pop #247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

arfibintang
Copy link

  • 🔍 I have searched the data.js file and confirmed I am not adding a duplicate entry, unless it is a different version of a song.
  • 💜 I have checked Issues and Pull Requests to confirm I am not adding a duplicate entry that is pending approval.
  • 🖍️ I have placed the new song(s) in alphabetical order based on title inside of the data.js file.
  • 🖍️ The artist(s) and featured artist(s) are all inside of square brackets [ ] and each are individually wrapped in quotation marks and have a comma between each one. (such as submitting this "artist": ["Lady Gaga","Bradley Cooper"] and not this "genres":["Lady Gaga,Bradley Cooper"]).
  • 3️⃣ I have at least three emojis listed under emojiImgs
  • 6️⃣ I have a maximum of six emojis listed under emojiImgs.
  • 🖍️ I have added a link to an official music video or performance under musicVideo. If there is no official video, I have added an empty string.
  • 👍 My pull request has a descriptive title (such as Added Boy With Luv or Added all of Panic at the Disco songs)
  • ⭐ My genres are all inside of square brackets [ ] and each are individually wrapped in quotation marks and have a comma between each one. (such as submitting this "genres": ["k-pop","pop","dance"] and not this "genres":["k-pop, pop, dance"]).
  • 📅 I have added a single year under year.

@brittanyrw
Copy link
Owner

@arfibintang This looks great! There is just one small update that needs to be made before we merge this in. Could you please place your objects in alphabetical order within the data.js file. They shouldn't all be at the bottom. This helps to prevent merge conflicts and when the file has a lot more info, it will help prevent duplicates as well.

Once you do that we can get these three cards live on the site. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants