Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto scaler will work only with jenkins node registred with label #19

Merged
merged 4 commits into from
Jan 15, 2023

Conversation

Shareed2k
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #19 (6957554) into master (0df1922) will increase coverage by 6.27%.
The diff coverage is 82.10%.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   62.92%   69.20%   +6.27%     
==========================================
  Files           5        6       +1     
  Lines         553      669     +116     
==========================================
+ Hits          348      463     +115     
  Misses        178      178              
- Partials       27       28       +1     
Impacted Files Coverage Δ
pkg/backend/type/gce/gce.go 19.58% <ø> (ø)
pkg/backend/type/gce/url_parser.go 85.71% <ø> (ø)
pkg/scaler/scaler.go 76.37% <79.62%> (+4.09%) ⬆️
pkg/scaler/client/client.go 90.58% <85.36%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a64e764...6957554. Read the comment docs.

@Shareed2k Shareed2k marked this pull request as ready for review January 11, 2023 08:29
pkg/backend/registry.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/scaler/client/client_test.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/scaler/scaler.go Show resolved Hide resolved
pkg/scaler/scaler.go Outdated Show resolved Hide resolved
@Shareed2k Shareed2k requested a review from shamil January 12, 2023 07:58
pkg/config/config.go Outdated Show resolved Hide resolved
@Shareed2k Shareed2k requested a review from shamil January 12, 2023 08:24
@shamil shamil removed their assignment Jan 12, 2023
@hagaibarel hagaibarel assigned Shareed2k and unassigned hagaibarel Jan 14, 2023
@Shareed2k Shareed2k merged commit e15bd46 into master Jan 15, 2023
@Shareed2k Shareed2k deleted the add_labels_support branch January 15, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants