Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change aws resize fnc and minimize count of request to backend api #17

Merged
merged 3 commits into from
Nov 7, 2022

Conversation

Shareed2k
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #17 (21baa02) into master (0df1922) will increase coverage by 6.05%.
The diff coverage is 74.57%.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   62.92%   68.98%   +6.05%     
==========================================
  Files           5        6       +1     
  Lines         553      661     +108     
==========================================
+ Hits          348      456     +108     
+ Misses        178      177       -1     
- Partials       27       28       +1     
Impacted Files Coverage Δ
pkg/backend/type/gce/gce.go 19.58% <ø> (ø)
pkg/backend/type/gce/url_parser.go 85.71% <ø> (ø)
pkg/scaler/scaler.go 76.02% <62.50%> (+3.73%) ⬆️
pkg/scaler/client/client.go 90.10% <82.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 285fb64...21baa02. Read the comment docs.

pkg/backend/type/aws/aws.go Outdated Show resolved Hide resolved
Copy link
Member

@shamil shamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update example and the readme with the region option

@shamil shamil removed their assignment Nov 7, 2022
@Shareed2k Shareed2k changed the title change aws resize fnc and minimize count of request to aws api change aws resize fnc and minimize count of request to backend api Nov 7, 2022
@hagaibarel hagaibarel assigned Shareed2k and unassigned hagaibarel Nov 7, 2022
@Shareed2k Shareed2k merged commit 9ef0307 into master Nov 7, 2022
@Shareed2k Shareed2k deleted the change_aws_resize branch November 7, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants