Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only Render Histogram if you Can #3094

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Only Render Histogram if you Can #3094

merged 1 commit into from
Jun 13, 2024

Conversation

jameskerr
Copy link
Member

@jameskerr jameskerr commented Jun 12, 2024

Hello!

These changes will improve a few things.

  1. If there is no pool name present in the query, this histogram will not render.
  2. If you press Cmd+L (on macOS) or Ctrl+L (on Linux/Windows), the editor will receive focus.
  3. If you switch tabs to a query session, the editor will receive focus automatically.

fixes #3093

Copy link
Contributor

@philrz philrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested out the branch and it's a functional 👍 for me.

As would be expected, the Cmd+L behavior on macOS worked as Ctrl+L on Linux, so I updated the PR text to reflect that's expected. Also, while the "focus automatically" sounds like what we want, I banged on some older releases and in everything I tried the cursor always landed in the editor as soon as I selected a tab with a Query Session anyway. But if these changes make it extra certain that'll happen a la "belt & suspenders", I'm all about it. 😄

@jameskerr jameskerr merged commit 71f9ca2 into main Jun 13, 2024
4 checks passed
@jameskerr jameskerr deleted the histogram-error-message branch June 13, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta-query returns "SyntaxError: Unexpected end of JSON input"
2 participants