Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Node Fetch #3061

Merged
merged 4 commits into from
May 2, 2024
Merged

Native Node Fetch #3061

merged 4 commits into from
May 2, 2024

Conversation

jameskerr
Copy link
Member

@jameskerr jameskerr commented May 1, 2024

Update electron dependencies.
Drop node-fetch 🙌
Use node native fetch
It required I add the duplex: "half" option when sending a post body.

@jameskerr jameskerr requested review from nwt and philrz May 1, 2024 22:40
@jameskerr jameskerr changed the title Update Electron to v30 Native Node Fetch May 1, 2024
Copy link
Contributor

@philrz philrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jameskerr did some Q&A with me on a brief Zoom and I'm now 👍 on these changes. I've also confirmed that once these changes are in place the fix to #3056 should be a one-liner. In the interest of addressing one thing at a time I'll put up a PR for that once this merges.

@jameskerr jameskerr merged commit ca047c0 into main May 2, 2024
2 of 3 checks passed
@jameskerr jameskerr deleted the update-electron branch May 2, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants