Add load/export support for TSV #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrz
commented
Dec 1, 2023
| @@ -51,7 +51,7 @@ import { getPath } from 'zui-test-data'; | |||
|
|
|||
| play('Preview & Load', (app, test) => { | |||
| test('create new pool, change key, type <enter>', async () => { | |||
| await app.dropFile(getPath('sample.tsv')); | |||
| await app.dropFile(getPath('sample.zeektsv')); | |||
There was a problem hiding this comment.
I took the liberty of renaming the popular sample.tsv to sample.zeektsv as part of this PR. Since we now support what's more widely thought of as "TSV" (i.e., generic), using the .tsv extension on the Zeek-specific variant felt wrong.
nwt
approved these changes
Dec 5, 2023
Co-authored-by: Noah Treuhaft <noah.treuhaft@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that TSV read/write support exists in Zed (brimdata/zed#4746) this enables it in Zui as well.
In addition to the tests that will be triggered in CI, I've confirmed locally that all the e2e tests run successfully with this branch.
Closes #2908