Improve .github/workflows/advance-zed.yml #2761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nwt
commented
May 4, 2023
•
nwt
commented
- Add on.workflow_dispatch for testing.
- Use the setup-zui action.
- Set user.name and user.email in the "git commit" step.
- Change user.name to "Brim Automation" as in brimdata/brimcap.
nwt
force-pushed
the
improve-advance-zed.yml
branch
from
dc8ef93
to
610359e
Compare
nwt
force-pushed
the
improve-advance-zed.yml
branch
2 times, most recently
from
9d67a67
to
f2c09b9
Compare
* Add on.workflow_dispatch for testing. * Use the setup-zui action. * Set user.name and user.email in the "git commit" step. * Change user.name to "Brim Automation" as in brimdata/brimcap.
nwt
force-pushed
the
improve-advance-zed.yml
branch
from
f2c09b9
to
d281d94
Compare
philrz
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
LGTM. 👍 Given brimdata/zed#4690 I expect you intend to next update setup-zui to use the Go version in go.mod rather than the explicit ref to 1.19, eh?
I do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.