Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how temporary storage is used #1801

Merged
merged 5 commits into from
Sep 1, 2021
Merged

Document how temporary storage is used #1801

merged 5 commits into from
Sep 1, 2021

Conversation

philrz
Copy link
Contributor

@philrz philrz commented Aug 31, 2021

When working on an issue-at-scale recently with a community user, I became concerned that maybe our software was consuming too much temporary storage on their system. This made me realize that we're overdue to reveal this information so users have a chance of doing this kind of debug on our own, or at least I could easily point them to an article if this comes up again. As it turns out, I think this info grafts nicely onto the existing Filesystem Paths article.

While running tests to write this content, I actually found multiple bugs where we're not currently cleaning up after ourselves the way we should (brimdata/brimcap#136, brimdata/zed#2983). Normally in these situations I'd confess these issues in the article, link to them, and then update the article once they get fixed. However, I have high hopes we'll get these fixed pretty quick, so for now I've kept it tidy.

@philrz philrz self-assigned this Aug 31, 2021
Comment on lines 143 to 145
appropriate location for each supported platform. As a result, temporary
storage should always be freed up automatically by the OS during normal
operations, such as when performing a system restart. However, bugs or abrupt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a result, temporary storage should always be freed up automatically by the OS during normal operations, such as when performing a system restart.

I don't think Windows does this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nwt: Thanks for mentioning this! My bad... I'd checked on macOS and Ubuntu and made a bit of "QED" leap. Indeed, I just ran a quick test and confirmed that Windows does not clean %TMP% on a reboot. Then I was reminded of the many free (or paid!) "cleanup" tools for Windows that purport to address this pressing challenge. 🙄

As if that's not bad enough, this made me paranoid enough that I figured I couldn't necessarily assume that what I observed for Ubuntu could hold for other Linux distros, so I tried CentOS. I figured if I covered at least those two I could call it a trend. Sure enough, CentOS didn't clean /tmp between reboots either!

I've now pushed a commit that's more vague about how reboots or "common cleanup utilities" might reap the temp space, but no guarantees. I know I'm probably overcompensating by saying any of this, but since in light of recent bugs we know Zed has the capacity to chow a whole lot of temp space, I'd like to be able to say we'd warned the people somewhere...

docs/Filesystem-Paths.md Outdated Show resolved Hide resolved
docs/Filesystem-Paths.md Outdated Show resolved Hide resolved
@philrz philrz merged commit 4b239c7 into main Sep 1, 2021
@philrz philrz deleted the temp-filesystem-paths branch September 1, 2021 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants