Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1660
Improve the Record#has method to check for the name and type of a field. Thanks to @mccanne , we can use strict equality to check the types of fields.
For example:
It also can check for more than one type by passing in more types:
I also found some more code in the log detail area that did not get the syntax upgrade in #1645
They have been fixed and I moved the programs to the "programs.ts" file. I hope to have all zed programs localized to this file in case we need to change the syntax again.
Finally, I realized that if we had some integration tests covering the log detail pane, we would not have so many regressions. I plan to add some shortly.