fix quotes for brimcap cli args #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mason Fish <mason@looky.cloud>
jameskerr
approved these changes
Apr 30, 2021
mason-fish
force-pushed
the
fix-brimcap-api-quotes
branch
from
29fa0d5
to
1cb01d3
Compare
nwt
reviewed
Apr 30, 2021
plugins/brimcap/brimcap-cli.ts
Outdated
Comment on lines
66
to
72
| this.binPath, | ||
| `"${this.binPath}"`, | ||
| subCommand, | ||
| ...flatMap( | ||
| Object.entries(opts).map(([k, v]) => [`-${OPTION_NAME_MAP[k] || k}`, v]) | ||
| Object.entries(opts).map(([k, v]) => [ | ||
| `-${OPTION_NAME_MAP[k] || k}`, | ||
| `"${v}"` | ||
| ]) |
There was a problem hiding this comment.
This can go sideways if this.binPath or any opts value contains a quotation mark (very unlikely but possible). Make it bulletproof by switching from execSync to spawnSync!
Signed-off-by: Mason Fish <mason@looky.cloud>
mason-fish
force-pushed
the
fix-brimcap-api-quotes
branch
from
0fca927
to
7c3c3a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1597
Signed-off-by: Mason Fish mason@looky.cloud