Fix Responsive Toolbar Buttons #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskerr
force-pushed
the
toolbar-fix
branch
2 times, most recently
from
26e68bb
to
9661c56
Compare
mason-fish
approved these changes
Apr 12, 2021
| @@ -13,8 +13,6 @@ export const LOG = createLogger({ | |||
| }) | |||
| ), | |||
| transports: [ | |||
| new transports.Console({level: "info"}), // No idea how to make this runtime-configurable via command line. This has | |||
There was a problem hiding this comment.
Are you removing this because "info" is already the default log level?
There was a problem hiding this comment.
This was just making the output on CI annoyingly long. The detailed info is in the file still, but doesn't clutter the console.
| @@ -14,7 +14,7 @@ | |||
| "start": "node scripts/start", | |||
| "test": "jest", | |||
| "test:api": "node scripts/test/api", | |||
| "itest": "jest --config=itest/config.json --runInBand --verbose", | |||
There was a problem hiding this comment.
Will this still show the same detail/verbosity when tests fail?
There was a problem hiding this comment.
Yes, it shows the failures like a normal jest runner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1538
The duration under the space title will now not appear if there is no duration (it actually already did this). The focus of this PR is actually some improvements to the page header.
Moved the toolbar buttons up on the same row as the space title. It collapses sensibly as you make the window smaller. It first shrinks the title until the min-width of 150px, then it starts moving toolbar buttons into the context menu. I also removed little blue icon from the title.