Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade electron to 11.2.1 #1426

Merged
merged 2 commits into from
Feb 12, 2021
Merged

Upgrade electron to 11.2.1 #1426

merged 2 commits into from
Feb 12, 2021

Conversation

jameskerr
Copy link
Member

@jameskerr jameskerr commented Feb 5, 2021 •
edited
Loading

The React DevTools are broken in version 8 - 11. The fix is in electron master. This helps us get up to speed when the fix is in.

mason-fish
mason-fish approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@mason-fish mason-fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to get those dev tools back! lgtm, assuming those failing iTests aren't related to the bump

@jameskerr
Copy link
Member Author

Oh shoot, we need to upgrade Spectron as well.

@jameskerr jameskerr merged commit 7d9bb77 into master Feb 12, 2021
@jameskerr jameskerr deleted the upgrade-electron branch February 12, 2021 16:51
@philrz philrz changed the title Upgrade eletron to 11.2.1 Upgrade electron to 11.2.1 Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mason-fish mason-fish mason-fish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameskerr @mason-fish