Add "source" field to JSON typing config for Zeek "weird" events #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brim-bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
…"weird" events" by philrz This is an auto-generated commit with a zq dependency update. The zq PR brimdata/zed#1884, authored by @philrz, has been merged. Add "source" field to JSON typing config for Zeek "weird" events I compiled Zeek 4.0.0-rc1 and ran [print-types.zeek](https://github.com/brimsec/zeek/blob/master/brim/print-types.zeek) against it and found they've added one additional field beyond what we were covering in Zeek 3.x: A `source` field in `weird` events. While our current JSON typing system is hopefully not long for this earth, since users may start using Zeek 4.x before the new approach is complete, I've added the additional field here. This is a companion PR to #1307 on the Brim side.
alfred-landrum
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I compiled Zeek 4.0.0-rc1 and ran print-types.zeek against it and found they've added one additional field beyond what we were covering in Zeek 3.x: A
sourcefield inweirdevents. While our current JSON typing system is hopefully not long for this earth, since users may start using Zeek 4.x before the new approach is complete, I've added the additional field here.Incidentally, in the past I'd not really confronted the config duplication that appears to be in play here. I suppose if we were building this from scratch now, we'd extend the "zq as a dependency in
node_modules" approach to have the contents of https://github.com/brimsec/zq/blob/master/zeek/types.json automatically reflected in the Brim-side config whenever it changes on the zq side. I'm not proposing we do this since we may never need to use this approach again, but noting it for the record.This is a companion PR to brimdata/zed#1884 on the zq side.