vam: Add network_of() func #5306
Open
+183
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattnibs
force-pushed
the
vam-network-of
branch
2 times, most recently
from
2373fa5
to
2b0ef9e
Compare
nwt
reviewed
Oct 1, 2024
Comment on lines
-50
to
+52
| out := vector.NewArray(f.outerTyp, outOffs, inner, nil) | ||
| if len(errs) > 0 { | ||
| return vector.Combine(out, errs, vector.NewStringError(f.zctx, "missing", uint32(len(errs)))) | ||
| } | ||
| return out | ||
| b := vector.NewCombiner(vector.NewArray(f.outerTyp, outOffs, inner, nil)) | ||
| b.Add(errs, vector.NewStringError(f.zctx, "missing", uint32(len(errs)))) | ||
| return b.Result() |
There was a problem hiding this comment.
vector.Combine feels like a better API here than vector.NewCombiner since the latter allocates a vector.Error even when len(errs)==0. Why not stick with it?
There was a problem hiding this comment.
Doesn't work for multiple error values
There was a problem hiding this comment.
Then how about using an API that works for multiple error values when you need that and an API that doesn't do unnecessary allocations when you don't?
mattnibs
force-pushed
the
vam-network-of
branch
from
2b0ef9e
to
ecf5036
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.