Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix strftime docs and add another example #5204

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Fix strftime docs and add another example #5204

merged 2 commits into from
Aug 6, 2024

Conversation

philrz
Copy link
Contributor

@philrz philrz commented Aug 5, 2024

While trying out the new strftime function added in #5197 I found a couple small errors to fix, and while I was at it I figured it could use another example.

@philrz philrz requested a review from a team August 5, 2024 23:45
@philrz philrz self-assigned this Aug 5, 2024
nwt
nwt approved these changes Aug 6, 2024
View reviewed changes
docs/language/functions/README.md Outdated Show resolved Hide resolved
@philrz @nwt
PR feedback: Fix order
abb8124 
Co-authored-by: Noah Treuhaft <noah.treuhaft@gmail.com>
@philrz philrz merged commit 038a6ef into main Aug 6, 2024
4 checks passed
@philrz philrz deleted the strftime-doc-fixes branch August 6, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwt nwt nwt approved these changes

Assignees

@philrz philrz

Labels
skip-autoperf skip-notify-downstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philrz @nwt