Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Unicode identifiers #4796

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Support Unicode identifiers #4796

merged 1 commit into from
Oct 16, 2023

Conversation

mattnibs
Copy link
Collaborator

@mattnibs mattnibs commented Oct 5, 2023

Part of: #4745

@mattnibs mattnibs requested a review from a team October 5, 2023 20:47
nwt
nwt approved these changes Oct 13, 2023
View reviewed changes
compiler/parser/parser.peg Outdated Show resolved Hide resolved
compiler/parser/parser.peg Outdated Show resolved Hide resolved
@nwt nwt changed the title Support Unicode Identifiers Support Unicode identifiers Oct 13, 2023
@mattnibs mattnibs force-pushed the unicode-id branch 2 times, most recently from fe85a0c to 9fa2b95 Compare October 13, 2023 21:25
nwt
nwt approved these changes Oct 16, 2023
View reviewed changes
compiler/parser/parser.peg Outdated Show resolved Hide resolved
compiler/parser/parser.peg Outdated Show resolved Hide resolved
@mattnibs mattnibs merged commit 76d8e2f into main Oct 16, 2023
3 checks passed
@mattnibs mattnibs deleted the unicode-id branch October 16, 2023 18:59
@philrz philrz linked an issue Oct 17, 2023 that may be closed by this pull request
Accept unicode letters in keyword search terms #4745
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwt nwt nwt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accept unicode letters in keyword search terms
2 participants
@mattnibs @nwt