Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty preferred languages list breaks Brief feeds display #274

Open
tanriol opened this issue Nov 6, 2017 · 2 comments
Open

Empty preferred languages list breaks Brief feeds display #274

tanriol opened this issue Nov 6, 2017 · 2 comments

Comments

@tanriol
Copy link
Member

tanriol commented Nov 6, 2017

If the preferred languages list in the Firefox settings is empty, navigator.language returns an empty string (which seems to contradict both WHATWG and W3C standards. This causes toLocaleString to throw an exception.

Reported in the support thread.
@tanriol
Copy link
Member Author

tanriol commented Nov 7, 2017

Filed a Firefox bug.

@CarlosGS
Copy link

Thank you for reporting this, I could not see any feeds for the last couple days.
Adding a preferred language has fixed the problem, indeed.
Cheers!

@tanriol tanriol mentioned this issue Feb 14, 2020
Open
Cimbali added a commit to Cimbali/brief that referenced this issue Mar 2, 2020
@Cimbali
Consistently use browser.i18n language
eb68a48 
Make the language used for date formatting and document lang attribute
consistent with the language used for strings by using browser.i18n for
both mechanisms (instead of something relying on navigator.language
which is a different setting).

Also fixes the problems when navigator.language is not specified, see brief-rss#487 and brief-rss#274.
@Cimbali Cimbali mentioned this issue Mar 2, 2020
Open
Cimbali added a commit to Cimbali/brief that referenced this issue May 26, 2020
@Cimbali
Consistently use browser.i18n language
8985709 
Make the language used for date formatting and document lang attribute
consistent with the language used for strings by using browser.i18n for
both mechanisms (instead of something relying on navigator.language
which is a different setting).

Also fixes the problems when navigator.language is not specified, see brief-rss#487 and brief-rss#274.
Cimbali added a commit to Cimbali/brief that referenced this issue Aug 11, 2020
@Cimbali
Consistently use browser.i18n language
ba7e22d 
Make the language used for date formatting and document lang attribute
consistent with the language used for strings by using browser.i18n for
both mechanisms (instead of something relying on navigator.language
which is a different setting).

Also fixes the problems when navigator.language is not specified, see brief-rss#487 and brief-rss#274.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tanriol @CarlosGS