Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add ability to set maxBuffer parameter for spawnSync while executing checkov #9

Merged
merged 1 commit into from
Oct 8, 2023
Merged

feat: Add ability to set maxBuffer parameter for spawnSync while executing checkov #9

merged 1 commit into from
Oct 8, 2023

Conversation

romanoff
Copy link
Contributor

This was result of #8 . When spawnSync was called, Error: spawnSync checkov ENOBUFS error could be returned if checkov command returned a lot of content. Turns out that this error could be avoided if maxBuffer value for spawnSync was increased (1 Mb by default). This PR allows to change this value by setting CHECKOV_MAX_BUFFER_SIZE_MB environment variable.

gruebel
gruebel approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay 🙈 next time just tag me, then I have better visibility with the created PR. Great work and thanks for the contribution 🏆

@gruebel gruebel merged commit f0748c4 into bridgecrewio:main Oct 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruebel gruebel gruebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romanoff @gruebel