Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomEntitySyntax slowing down saving considerably #84

Closed
solvedDev opened this issue Oct 10, 2021 · 5 comments · Fixed by bridge-core/plugins#95
Closed

CustomEntitySyntax slowing down saving considerably #84

solvedDev opened this issue Oct 10, 2021 · 5 comments · Fixed by bridge-core/plugins#95
Assignees
Labels
bug Something isn't working
Milestone

Comments

@solvedDev
Copy link
Member

No description provided.

@solvedDev solvedDev moved this to 📝 Todo in bridge. v2 Oct 10, 2021
@solvedDev solvedDev added the bug Something isn't working label Oct 10, 2021
@solvedDev solvedDev moved this from 📝 Todo to 📚 Backlog in bridge. v2 Oct 10, 2021
@Tschipp
Copy link

Tschipp commented Oct 17, 2021

I suspect that the reason for this is that all entity files need to be recompiled when any change to an entity is made, indicated by the fact that the AC depends on all entity files:
https://github.com/bridge-core/plugins/blob/master/plugins/CustomEntitySyntax/src/customEntitySyntax.js#L204
I suggest that a separate animation controller file should be created for every entity, to avoid having to recompile all entities every time.

@solvedDev solvedDev added this to the v2.2.0 milestone Dec 18, 2021
@solvedDev
Copy link
Member Author

This problem should hopefully be a bit better with our new compiler Dash because there's now a clear distinction between files we need to load to process changes to a file and files that actually change their content when a file changes.
In this case, this means that if you update an entity file, bridge. will only save the entity file & animation controller to the output directory. We still need to load all entity files though so the best solution is still to generate a single virtual animation controller for every entity

@Tschipp
Copy link

Tschipp commented Dec 19, 2021

In this case, this means that if you update an entity file, bridge. will only save the entity file & animation controller to the output directory.

Interesting, I thought that's how it always worked

@solvedDev
Copy link
Member Author

Yeah, that's how it should have always worked but previously the only difference between hot updates and full builds was with which files we call the build algorithm. (We would do a dependency trace step before the hot update). This was never intended to be a permanent compilation algorithm but the advantage of it was that -in theory- it should have been very reliable because we do more work than necessary instead of missing file update edge cases. This obviously turned out to not be the case because something broke the reliable architecture. I still suspect that the compilation problems are connected with the plugins users are running but I have no evidence to proof that.

@solvedDev solvedDev modified the milestones: v2.2.0, v2.3.0 Jan 7, 2022
@solvedDev
Copy link
Member Author

Delaying a rewrite of the plugin to v2.3.0

@solvedDev solvedDev modified the milestones: v2.3.0, v2.2.X Jan 16, 2022
Repository owner moved this from 📚 Backlog to 🚀 Done in bridge. v2 Jan 31, 2022
solvedDev pushed a commit that referenced this issue Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🚀 Done
Development

Successfully merging a pull request may close this issue.

3 participants