-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CustomEntitySyntax slowing down saving considerably #84
Comments
I suspect that the reason for this is that all entity files need to be recompiled when any change to an entity is made, indicated by the fact that the AC depends on all entity files: |
This problem should hopefully be a bit better with our new compiler Dash because there's now a clear distinction between files we need to load to process changes to a file and files that actually change their content when a file changes. |
Interesting, I thought that's how it always worked |
Yeah, that's how it should have always worked but previously the only difference between hot updates and full builds was with which files we call the build algorithm. (We would do a dependency trace step before the hot update). This was never intended to be a permanent compilation algorithm but the advantage of it was that -in theory- it should have been very reliable because we do more work than necessary instead of missing file update edge cases. This obviously turned out to not be the case because something broke the reliable architecture. I still suspect that the compilation problems are connected with the plugins users are running but I have no evidence to proof that. |
Delaying a rewrite of the plugin to v2.3.0 |
No description provided.
The text was updated successfully, but these errors were encountered: