Continue cleaning, add action

.github/workflows/ruff.yml

@@ -0,0 +1,14 @@
+name: Ruff
+on: [push, pull_request]
+jobs:
+  ruff:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: chartboost/ruff-action@v1
+        with:
+          - changed-files: 'true'
+      - uses: chartboost/ruff-action@v1
+        with:
+          - changed-files: 'true'
+          - args: 'format --check'

python/PiFinder/audit_images.py

@@ -17,7 +17,6 @@ def get_catalog_objects():
         "/Users/rich/Projects/Astronomy/PiFinder/astro_data/pifinder_objects.db"
     )
     conn.row_factory = sqlite3.Row
-    db_c = conn.cursor()
     cat_objects = conn.execute(
         """
         SELECT * from objects
@@ -40,7 +39,6 @@ def check_object_image(catalog_object):
             "/Users/rich/Projects/Astronomy/PiFinder/astro_data/pifinder_objects.db"
         )
         conn.row_factory = sqlite3.Row
-        db_c = conn.cursor()
 
         aka_rec = conn.execute(
             f"""

python/PiFinder/calc_utils.py

@@ -241,7 +241,7 @@ def altaz_to_radec(self, alt, az, dt):
 
         observer = self.observer_loc.at(t)
         a = observer.from_altaz(alt_degrees=alt, az_degrees=az)
-        ra, dec, distance = a.radec(epoch=t)
+        ra, dec, _distance = a.radec(epoch=t)
         return ra._degrees, dec._degrees
 
     def radec_to_altaz(self, ra, dec, dt, atmos=True):
@@ -260,9 +260,9 @@ def radec_to_altaz(self, ra, dec, dt, atmos=True):
 
         apparent = observer.observe(sky_pos).apparent()
         if atmos:
-            alt, az, distance = apparent.altaz("standard")
+            alt, az, _distance = apparent.altaz("standard")
         else:
-            alt, az, distance = apparent.altaz()
+            alt, az, _distance = apparent.altaz()
         return alt.degrees, az.degrees
 
     def radec_to_constellation(self, ra, dec):

python/PiFinder/db/observations_db.py

@@ -151,7 +151,7 @@ def check_logged(self, obj_record: CompositeObject):
         Returns true/false if this object has been observed
         """
         # safety check
-        if self.observed_objects_cache == None:
+        if self.observed_objects_cache is None:
             self.load_observed_objects_cache()
 
         if (
@@ -198,7 +198,7 @@ def get_sessions(self, session_uid=None):
                     avg(lon) as lon
                 from obs_sessions
             """
-        if session_uid != None:
+        if session_uid is not None:
             # add in a where clause
             q += """
                 where uid= :sess_uid
@@ -236,7 +236,7 @@ def get_session(self, session_uid):
         returns a record for a specific session
         applies the same enrichment
         """
-        return get_sessions(session_uid=session_uid)[0]
+        return self.get_sessions(session_uid=session_uid)[0]
 
     def get_logs_by_session(self, session_uid):
         """