Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback Media Player standardization #757

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

brianwernick
Copy link
Owner

@brianwernick brianwernick commented Aug 2, 2022

  • This pull request follows the coding standards

Adds

  • Created a FallbackMediaPlayer that handles the "native" fallback media playback using the system MediaPlayer. This standardization better allows us to track the playback state (useful for Playback state callback #257) and keep the handling consistent between the Video and Audio players

…yers use instead of the MediaPlayer directly. This allows us to better standardize handling and keep track of playback state (useful for #257; playback state callback)
@brianwernick brianwernick added this to the 5.0.0 milestone Aug 2, 2022
@brianwernick brianwernick merged commit ac5b5c6 into master Aug 2, 2022
@brianwernick brianwernick deleted the bmw/fallback-media-player-standardization branch August 2, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant