Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add href to health check responses #34

Merged
merged 1 commit into from
Dec 24, 2022
Merged

add href to health check responses #34

merged 1 commit into from
Dec 24, 2022

Conversation

briantist
Copy link
Owner

Addendum to #33 adding an href field to health check responses.
This can be useful to ensure URL generation is working.
Also fixed some formatting.

cc @jcox10

@briantist briantist added the enhancement New feature or request label Dec 24, 2022
@briantist briantist self-assigned this Dec 24, 2022
@codecov
Copy link

codecov bot commented Dec 24, 2022

Codecov Report

Base: 51.94% // Head: 51.77% // Decreases project coverage by -0.17% ⚠️

Coverage data is based on head (2a990b3) compared to base (0a676a5).
Patch coverage: 11.11% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   51.94%   51.77%   -0.18%     
==========================================
  Files          22       22              
  Lines         872      875       +3     
==========================================
  Hits          453      453              
- Misses        419      422       +3     
Impacted Files Coverage Δ
galactory/api/v2/collections.py 20.75% <0.00%> (ø)
galactory/health/v1/health_checks.py 40.74% <20.00%> (-5.10%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@briantist briantist merged commit bfd1119 into main Dec 24, 2022
@briantist briantist deleted the healthcheck/href branch December 24, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant