Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new factory method
create_configured_app
, and pushes all of the "main" CLI code into that method.The idea is to use the CLI (and especially config and environment) parsing to set the options so that they don't all have to be set explicitly as they do in the bare
create_app
method.This should be helpful for using galactory with a production WSGI server.
For example, with this change, you could run
gunicorn -w 4 'galactory:create_configured_app()'
and it would take values from environment variables and your config file(s).I haven't tried it with other WSGI servers yet, but at least with
gunicorn
it also works to specify additional CLI arguments, for example:gunicorn -w 4 'galactory:create_configured_app()' --log-level DEBUG
The existing method of running with the built-in werkzeug server is unchanged and still works.